[snmp] Support new profiles without throwing errors in translate-profiles #10648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
AlexandreYang
approved these changes
Dec 6, 2021
cswatt
pushed a commit
that referenced
this pull request
Jan 5, 2022
…iles (#10648) * [snmp] support new profiles without throwing errors * [snmp] support profiles with no metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
ddev meta snmp translate-profilemigrates legacy MIB based profiles to the current OID based format. The tool was triggering exceptions when executed over OID based format, as it was expecting string values but was getting dictionaries.This PR skips OID based format metrics.
Motivation
Exceptions triggered when QAing #10353
Additional Notes
Testing:
Running
ddev meta snmp translate-profile snmp/datadog_checks/snmp/data/profiles/cisco-nexus.yamlshould not trigger any error.Running
ddev meta snmp translate-profile snmp/datadog_checks/snmp/data/profiles/cisco-asa.yamlshould not trigger any error.Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached