Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dd_run_check for Cilium #10632

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Use dd_run_check for Cilium #10632

merged 1 commit into from
Nov 29, 2021

Conversation

yzhan289
Copy link
Contributor

@yzhan289 yzhan289 commented Nov 15, 2021 •
edited
Loading

What does this PR do?

QA for #8893

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@yzhan289 yzhan289 requested a review from a team as a code owner November 15, 2021 14:52
@codecov
Copy link

codecov bot commented Nov 15, 2021 •
edited
Loading

Codecov Report

Merging #10632 (17b01fe) into master (e668209) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Flag Coverage Δ
cilium 85.84% <100.00%> (+1.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@yzhan289 yzhan289 merged commit df143fe into master Nov 29, 2021
@yzhan289 yzhan289 deleted the az/cilium-config-validation branch November 29, 2021 22:49
cswatt pushed a commit that referenced this pull request Jan 5, 2022
@yzhan289 @cswatt
Use dd_run_check (#10632)
c02f1ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanny-jiang fanny-jiang fanny-jiang approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog integration/cilium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yzhan289 @fanny-jiang