Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document new option of OpenMetrics-based integrations #10601

Merged
merged 6 commits into from
Nov 13, 2021
Merged

Document new option of OpenMetrics-based integrations #10601

merged 6 commits into from
Nov 13, 2021

Conversation

olivielpeau
Copy link
Member

@olivielpeau olivielpeau commented Nov 10, 2021 •
edited
Loading

What does this PR do?

Documents the new use_process_start_time option of OpenMetrics-based integrations and adds it to config models.

Motivation

See #10463

Additional Notes

This PR is a split from #10463, only including the config model/example yaml changes of that PR to avoid CI timeouts. Completes #10589 which only included the base check code changes.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@olivielpeau olivielpeau requested review from a team as code owners November 10, 2021 20:31
@olivielpeau olivielpeau mentioned this pull request Nov 10, 2021
Closed
4 tasks
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@codecov
Copy link

codecov bot commented Nov 10, 2021 •
edited
Loading

Codecov Report

Merging #10601 (5e3bc54) into master (bfe5f7d) will decrease coverage by 0.03%.
The diff coverage is n/a.

Flag Coverage Δ
amazon_msk 88.83% <ø> (ø)
avi_vantage 91.92% <ø> (ø)
azure_iot_edge 81.93% <ø> (ø)
cilium 85.84% <ø> (+1.88%) ⬆️
cockroachdb 97.18% <ø> (ø)
coredns 95.74% <ø> (ø)
crio 100.00% <ø> (ø)
datadog_checks_dev 79.76% <ø> (ø)
datadog_cluster_agent 97.50% <ø> (ø)
etcd 93.27% <ø> (ø)
external_dns 100.00% <ø> (ø)
gitlab 89.94% <ø> (ø)
gitlab_runner 91.94% <ø> (ø)
haproxy 95.08% <ø> (+0.16%) ⬆️
istio 76.87% <ø> (+0.57%) ⬆️
kong 92.21% <ø> (ø)
kube_apiserver_metrics 97.35% <ø> (ø)
kube_scheduler 96.20% <ø> (ø)
linkerd 85.14% <ø> (+1.14%) ⬆️
nginx_ingress_controller 98.30% <ø> (ø)
openmetrics 97.14% <ø> (ø)
scylla 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@olivielpeau olivielpeau force-pushed the olivielpeau/openmetrics-process-start-time-doc branch from d536862 to a3bbc92 Compare November 12, 2021 10:36
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@olivielpeau olivielpeau force-pushed the olivielpeau/openmetrics-process-start-time-doc branch from a3bbc92 to 38aa927 Compare November 12, 2021 10:45
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@olivielpeau olivielpeau force-pushed the olivielpeau/openmetrics-process-start-time-doc branch from 38aa927 to 555c49b Compare November 12, 2021 11:00
@olivielpeau
Copy link
Member Author

@yzhan289 Thanks, should be fixed now, could you have another look?

fanny-jiang
fanny-jiang previously approved these changes Nov 12, 2021
View reviewed changes
yzhan289
yzhan289 previously approved these changes Nov 12, 2021
View reviewed changes
@fanny-jiang
Copy link
Contributor

Hey @olivielpeau, there are a couple other openmetrics checks that also need documenting, like vault and the other kube checks. I can make a PR to update those too, unless you have reason for them not to use the new option.

@olivielpeau
Copy link
Member Author

@fanny-jiang Yes they should be documented as well, if you could open a PR that'd be great thanks 🙇

@fanny-jiang fanny-jiang dismissed stale reviews from yzhan289 and themself via 20e3c15 November 12, 2021 21:21
@olivielpeau olivielpeau requested a review from a team as a code owner November 12, 2021 21:21
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@fanny-jiang fanny-jiang merged commit fc488c2 into master Nov 13, 2021
@fanny-jiang fanny-jiang deleted the olivielpeau/openmetrics-process-start-time-doc branch November 13, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanny-jiang fanny-jiang fanny-jiang approved these changes

@ofek ofek ofek approved these changes

@yzhan289 yzhan289 yzhan289 left review comments

@ruthnaebeck ruthnaebeck ruthnaebeck left review comments

Assignees
No one assigned
Labels
changelog/no-changelog dev/tooling integration/amazon_msk integration/avi_vantage integration/azure_iot_edge integration/cilium integration/cockroachdb integration/coredns integration/crio integration/datadog_checks_base integration/datadog_checks_dev integration/datadog_cluster_agent integration/etcd integration/external_dns integration/gitlab_runner integration/gitlab integration/haproxy integration/istio integration/kong integration/kube_apiserver_metrics integration/kube_dns integration/kube_metrics_server integration/kube_proxy integration/kube_scheduler integration/linkerd integration/nginx_ingress_controller integration/openmetrics integration/scylla integration/snowflake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@olivielpeau @yzhan289 @fanny-jiang @ofek @ruthnaebeck