Harmonize check and config options #10488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
kayayarai
previously approved these changes
Oct 25, 2021
| @@ -86,6 +86,12 @@ files: | |||
| If you want to keep the cert in a separate file, enter the file path here | |||
| value: | |||
| type: string | |||
| - name: appcenter | |||
| description: | | |||
| Whether or not appcenter user certificates are being used. | |||
There was a problem hiding this comment.
Suggested change
| Whether or not appcenter user certificates are being used. | |
| Whether App Center user certificates are being used. |
| @@ -119,6 +119,11 @@ instances: | |||
| # | |||
| # cert_key_path: <CERT_KEY_PATH> | |||
|
|
|||
| ## @param appcenter - boolean - optional - default: false | |||
| ## Whether or not appcenter user certificates are being used. | |||
There was a problem hiding this comment.
Suggested change
| ## Whether or not appcenter user certificates are being used. | |
| ## Whether App Center user certificates are being used. |
kayayarai
approved these changes
Oct 26, 2021
yzhan289
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
report_timingfrom the check. It wasn't listed in the config and was never used.appcenterconfig option to the spec.yaml. It was in the check, but the option was never listed in theconf.yaml.exampleappcenterrefers to whether or not the certs being used are appcenter user certs: datacenter/pyaci@8c5b61fMotivation
Bug fix
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached