Update dashboard validation for Manifest V2 #10398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
nmuesch
previously approved these changes
Oct 12, 2021
Comment on lines
+114
to
+115
| def get_path(self, path): | ||
| return self._manifest_json.get(path) |
There was a problem hiding this comment.
Are we using this get_path anywhere?
There was a problem hiding this comment.
No, but at one point in my PR I did - thought it would be useful to have so I left it.
ofek
requested changes
Oct 12, 2021
Comment on lines
+27
to
+29
| # add version constants to avoid extra imports | ||
| V1 = V1 | ||
| V2 = V2 |
There was a problem hiding this comment.
In the other file, by adding these enums here, it avoids an extra import statement which will also be helpful in other use cases
ofek
approved these changes
Oct 12, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Oct 12, 2021
* Update dashboard validation for Manifest V2 * Handle embedded widget objects in dashboards d46143f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds additional check for dashboards with Manifest V2 to check that the
app_ids align correctly.Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached