Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta command for browsing Windows performance counters #10385

Merged
merged 2 commits into from
Oct 11, 2021

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Oct 8, 2021

Motivation

Better tooling

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #10385 (22bdfc7) into master (0ecaa6b) will increase coverage by 0.00%.
The diff coverage is n/a.

Flag Coverage Δ
datadog_checks_dev 79.87% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@coignetp coignetp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add pypiwin32 to the deps?
Otherwise, seems to be working well 🔥

@ofek ofek merged commit cf19693 into master Oct 11, 2021
@ofek ofek deleted the ofek/pdh-explore branch October 11, 2021 16:29
github-actions bot pushed a commit that referenced this pull request Oct 11, 2021
* Add meta command for browsing Windows performance counters

* address cf19693
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants