Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batch option to ddev dep updates command #10229

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Conversation

sarah-witt
Copy link
Contributor

What does this PR do?

Adds a batch options to ddev dep updates command, so now you can specify the maximum number of dependencies to upgrade.

Motivation

It can be helpful to only update a few dependencies at a time, since it's easier to test, and there are less changes to focus on at once.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #10229 (66ffaee) into master (c28729a) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
datadog_checks_dev 80.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sarah-witt sarah-witt marked this pull request as ready for review September 24, 2021 19:05
@sarah-witt sarah-witt requested a review from a team as a code owner September 24, 2021 19:05
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this always exit after the first loop by default?

@sarah-witt
Copy link
Contributor Author

Wouldn't this always exit after the first loop by default?

Whoops, updated to handle that case!

@sarah-witt sarah-witt merged commit 3f338ab into master Sep 27, 2021
@sarah-witt sarah-witt deleted the sarah/add-batch-option branch September 27, 2021 13:06
github-actions bot pushed a commit that referenced this pull request Sep 27, 2021
* Add batch option to ddev dep updates command

* Handle case where batch size is not specified 3f338ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants