Change get_commits_since so that it won't take commits from other bra…

…nches (#12376)
DataDog · Jun 16, 2022 · cfd1625 · cfd1625
1 parent 549d9e0
commit cfd1625
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/datadog_checks_dev/datadog_checks/dev/tooling/git.py b/datadog_checks_dev/datadog_checks/dev/tooling/git.py
@@ -86,7 +86,7 @@ def get_commits_since(check_name, target_tag=None, end=None, exclude_branch=None
     elif exclude_branch is not None:
         command = f"git cherry -v {exclude_branch} HEAD {'' if target_tag is None else f'{target_tag} '}"
     else:
-        command = f"git log --pretty=%s {'' if target_tag is None else f'{target_tag}...{end} '}{target_path}"
+        command = f"git log --pretty=%s {'' if target_tag is None else f'{target_tag}..{end} '}{target_path}"
 
     with chdir(root):
         return run_command(command, capture=True, check=True).stdout.splitlines()

diff --git a/datadog_checks_dev/tests/tooling/test_git.py b/datadog_checks_dev/tests/tooling/test_git.py
@@ -90,7 +90,7 @@ def test_get_commits_since():
             chdir.assert_called_once_with('/foo/')
             get_commits_since('my-check', target_tag='the-tag')
             run.assert_any_call('git log --pretty=%s /foo/my-check', capture=True, check=True)
-            run.assert_any_call('git log --pretty=%s the-tag... /foo/my-check', capture=True, check=True)
+            run.assert_any_call('git log --pretty=%s the-tag.. /foo/my-check', capture=True, check=True)
 
 
 def test_git_show_file():