Skip to content

Commit

Permalink
Final fix for changelog validation (#15686)
Browse files Browse the repository at this point in the history
  • Loading branch information
ofek authored Aug 24, 2023
1 parent fa32e70 commit 6b7a8f4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions ddev/src/ddev/utils/scripts/check_pr.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def get_changelog_errors(git_diff: str, suffix: str, private: bool = False) -> l
return errors


def changelog_impl(*, ref: str, diff_file: str, pr_file: str) -> None:
def changelog_impl(*, ref: str, diff_file: str, pr_file: str, private: bool) -> None:
import json

on_ci = os.environ.get('GITHUB_ACTIONS') == 'true'
Expand All @@ -168,7 +168,7 @@ def changelog_impl(*, ref: str, diff_file: str, pr_file: str) -> None:
print('No changelog entries required (changelog/no-changelog label found)')
return

errors = get_changelog_errors(git_diff, changelog_entry_suffix(pr_number, pr_url))
errors = get_changelog_errors(git_diff, changelog_entry_suffix(pr_number, pr_url), private=private)
if not errors:
return
elif os.environ.get('GITHUB_ACTIONS') == 'true':
Expand Down

0 comments on commit 6b7a8f4

Please sign in to comment.