Skip to content

Conversation

@jreid-justworks
Copy link

CSI driver subchart 0.4.3 lacks tolerations templating, potentially causing incomplete deployment.

What this PR does / why we need it:

Use case: Cluster with nodes with NoSchedule for normal workloads, but which we want the csi driver daemonset deployed to. With current latest chart version, there is no way to apply tolerances to the daemonset other than hotpatching as , but datadog-csi-driver.tolerations is silently ignored.

Which issue this PR fixes

Special notes for your reviewer:

Test baseline changes are from drift in dependencies and not related to this change.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version semver bump label added: datadog/patch-version
  • For datadog or datadog-operator chart or value changes, update the test baselines (run: make update-test-baselines)

GitHub CI takes care of the below, but are still required:

  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md

CSI driver subchart 0.4.3 lacks tolerations templating, potentially causing incomplete deployment.
@jreid-justworks jreid-justworks requested a review from a team as a code owner December 22, 2025 21:15
@zhuminyi
Copy link
Contributor

zhuminyi commented Jan 6, 2026

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jan 6, 2026

View all feedbacks in Devflow UI.

2026-01-06 14:33:33 UTC ℹ️ Start processing command /merge


2026-01-06 14:33:45 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-01-06 14:34:45 UTC ⚠️ MergeQueue: This merge request was unqueued

minyi.zhu@datadoghq.com unqueued this merge request

@zhuminyi
Copy link
Contributor

zhuminyi commented Jan 6, 2026

/merge -c

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jan 6, 2026

View all feedbacks in Devflow UI.

2026-01-06 14:34:40 UTC ℹ️ Start processing command /merge -c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants