-
Notifications
You must be signed in to change notification settings - Fork 1k
Add migration k8s job #2122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
fanny-jiang
wants to merge
76
commits into
main
Choose a base branch
from
fanny/AGENTONB-2646/migration-k8s-job
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add migration k8s job #2122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bump version for datadog to 3.140.0 (minor-version) - update changelog for datadog with version 3.140.0 - update readme for datadog
- update readme for datadog
- update readme for datadog
- update readme for datadog
- bump version for datadog to 3.141.0 (minor-version) - update changelog version for datadog to 3.141.0 - update readme for datadog
- bump version for datadog to 3.141.0 (minor-version) - update changelog version for datadog to 3.141.0 - update readme for datadog
- bump version for datadog to 3.141.0 (minor-version) - update changelog for datadog with version 3.141.0 - update readme for datadog
7cc871e to
8b892ad
Compare
…B-2646/migration-k8s-job
31cd71a to
422e490
Compare
5 tasks
5707d11 to
d78f2a3
Compare
6d50bdc to
ca9ab7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
This branch includes changes from: #2112
Testing (in kind cluster)
Datadog operator pod should be running
Enable migration preview:
Check that the migration job pod is running and completes successfully (should be only 1 container running mapper binary)
Run the kubectl command shown in the helm upgrade notes output to view the mapping logs output. Check that the command works and review the logs output--there shouldn't be any errors (warnings are ok).
Enable migration:
Check that the migration job pod is running and completes successfully (should be 2 containers; 1 running mapper binary, another running kubectl)
Run the kubectl command shown in the helm upgrade notes output to view the migration logs output. Check that the command works and review the logs output--there shouldn't be any errors (warnings are ok). It should also confirm that the DDA has been created and annotated:
Check that a DatadogAgent custom resource has been created successfully:
kubectl get ddand the name is the same as the{{datadog.fullname}}.Check that a new daemonset has been created and its annotations indicate that it's being managed by the operator. The old helm-managed daemonset has been deleted.
Should return
datadog-operatordatadoghq.com/migrated: trueannotation:Should return
datadog-operatorTo test complete migration to the operator chart:
helm.sh/resource-policy: keepannotation:--take-ownershipflag:The DDA CRD annotations should now reflect ownership by the new operator chart release:
The DDA CRD should not get deleted and you should get this output:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
<chartName>/minor-version,<chartName>/patch-version, or<chartName>/no-version-bump)datadogordatadog-operatorchart or value changes, update the test baselines (run:make update-test-baselines)GitHub CI takes care of the below, but are still required:
.github/helm-docs.sh)CHANGELOG.mdhas been updatedREADME.md