[fix] static link dl #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbibby
requested review from
jmoiron,
benauthor,
akrylysov,
kenny-house and
kevinconaway
|
Does this mean that the library won't compile with rocksdb v5 anymore? We should probably update the README if so. |
|
I have not added anything that would prevent it compiling wtih v5 (that I know of). I will test the compile today to be sure. this is a conversation I am trying to start on the upstream. I would like to create a branch that supports rocksdb5 and start adding some of the missing features of 6 on master. (and update the readme accordingly). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added an
'ldlflag to the dynflag.go but we also need it in staticflag_linux.go when building a static library.