[REDRES-820] Add rocks options for compaction #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
az0977776
reviewed
Jul 1, 2024
| C.rocksdb_free(unsafe.Pointer(cErr)) | ||
| } | ||
|
|
||
| // free before return |
There was a problem hiding this comment.
I noticed the SetOptions function does not free the cstrings. Is that a bug or do we not need to free these?
There was a problem hiding this comment.
I think we probably do need to technically. Although I don't think it is super high impact since we would not be continuously setting options.
Might be a better idea to make a separate PR to fix that, though
az0977776
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.