Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream #10

Merged
merged 15 commits into from
Jan 7, 2020
Merged

Merge upstream #10

merged 15 commits into from
Jan 7, 2020

Conversation

kenny-house
Copy link

This PR merges the latest upstream commits (keeping the custom flags that were present in this fork).

Stumble and others added 15 commits July 16, 2019 17:06
Reference: facebook/rocksdb#1095

The cst has alredy been consumed when associated with the prefix_extractor
remove compression library link flags.
CreateNewBackupFlush, when flush is set to true, flushes the WAL
before creating the backup. When flush is set to false, it acts
exactly like CreateNewBackup and backups the WAL in a separate,
non-atomic operation.
Add missing table options and full bloom filter
Attempting to destroy the opts.cst will segfault
@kenny-house kenny-house requested a review from jamesbibby January 7, 2020 20:04
Copy link

@jamesbibby jamesbibby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kenny-house kenny-house merged commit 9722c3a into master Jan 7, 2020
@kenny-house kenny-house deleted the kenny.house/merge-upstream branch January 7, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants