Repository navigation
Namespace not being used with Sidekiq Pro #292
Description
We're using Datadog and have configured both DD and Sidekiq Pro to send Sidekiq metrics to our Datadog agent. However, when in Datadog the only way we can view the various metrics from Sidekiq is with the prefix jobs.*, rather than sidekiq.jobs.*.
Our Sidekiq config file (located in config/initializers/sidekiq.rb) looks like this:
require 'datadog/statsd' # gem 'dogstatsd-ruby'
Sidekiq.configure_server do |config|
config.dogstatsd = ->{ Datadog::Statsd.new(socket_path: ENV['SOCKET_PATH'], namespace: 'sidekiq') }
config.server_middleware do |chain|
require 'sidekiq/middleware/server/statsd'
chain.add Sidekiq::Middleware::Server::Statsd
end
endThe first line within the Sidekiq.configure_server block was originally not there. Previously we had this line outside the config block, set as:
Sidekiq::Pro.dogstatsd = ->{ Datadog::Statsd.new(socket_path: ENV['SOCKET_PATH'], namespace:'sidekiq') }Which resulted in no metrics being sent, maybe. We are seeing metrics in DD now, but we're unsure if it's because of the aforementioned code change or using the prefix jobs.* instead of sidekiq.jobs.*
Activity
travisTheOrange commentedon Aug 23, 2024
Is anyone able to help with this?
carlosroman commentedon Aug 27, 2024
Any reason why you've chosen the
namespaceas beingsidekiq? This is causing all metrics to havesidekiqappended to them, see here.travisTheOrange commentedon Aug 27, 2024
@carlosroman are you suggesting that even metrics not belonging to Sidekiq would have the prefix
sidekiq.*? So metrics from Datadog would all be prefixed withsidekiq.*?And I'd say that in theory it would cause all metrics to have the
sidekiq.*prefix, however, as per my raised issue, no metrics are being prefixed withsidekiq.*carlosroman commentedon Aug 27, 2024
Sorry, I thought you meant that all your metrics are getting
sidekiqappended to them. So adding anamespacedoesn't seem to actually prefix the metrics at the moment?travisTheOrange commentedon Aug 27, 2024
@carlosroman yeah exactly. Although I raised this issue in the Sidekiq repo and was told the issue is known and being worked on