Development/test environment in Rails #130

Activity

1. kbogtob commented on Feb 10, 2020

   

   kbogtob

   on Feb 10, 2020

   Contributor

   More actions

   Hi @ngan!

   Thanks for your feedback! l will investigate about the new connection at each call, I'll see if I can reproduce. Do you have any additional clues about that?

   About the development mode, it's in the work backlog but I can't tell you when it will be shipped. The code is currently being refactored and tests are being rewritten.

   Cheers!
2. ngan commented on Feb 10, 2020

   

   ngan

   on Feb 10, 2020

   Author

   More actions

   Do you have any additional clues about that?

   Unfortunately, I don't. We've patched it to not send requests and moved on from the issue. But basically every time we make a $redis.increment(...) or whatever call, we'd see a new connection with to port 8125 using lsof -i:8125.
3. arielvalentin commented on Apr 22, 2020

   

   arielvalentin

   on Apr 22, 2020

   More actions

   I am not sure if this is the best issue to comment on but I would be keen on being able to use a strategy similar to the FakeUDPSocket that this project uses in unit tests.

   https://github.com/DataDog/dogstatsd-ruby/blob/master/spec/statsd_spec.rb#L4

   Perhaps the constructor could take an additional value for socket_type that would use the fake implementation instead e.g. socket_type: :test
4. tatey commented on May 11, 2020

   

   tatey

   on May 11, 2020

   Last edited by tatey

   More actions

   @arielvalentin Me too! I've written two pieces of middleware based on dogstatsd. I used the FakeUDPSocket strategy to write the unit tests.

   If there's appetite I'd be happy to write a patch for dogstatsd did would let you do something like this:

   require "dogstatsd/test_helper"
   
   def test_the_thing
     socket = Datadog::FakeUDPSocket.new
     statsd = Datadog::Statsd.new(socket: socket)
     statsd.increment("foo.bar")
     assert_equal ["foo.bar:1|c"], socket.recv
   end

   Does that seem like a reasonable approach? Otherwise if we were to take it one step further we could do something like what @arielvalentin is proposing:

   def test_the_thing
     statsd = Datadog::Statsd.new(socket_path: :test)
     statsd.increment("foo.bar")
     assert_equal ["foo.bar:1|c"], statsd.test_socket.recv
   end

   @kbogtob Would you accept a patch that did something like this?
5. jamesjefferies commented on Jan 7, 2021

   

   jamesjefferies

   on Jan 7, 2021

   More actions

   How about setting up the DataDog config so that in the test environment, you have a simple configuration item:

     Datadog.configure do |c|
       c.tracer.enabled = false
     end