Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yael/istio docs updates #9688

Merged
merged 14 commits into from
Feb 4, 2021
Merged

Yael/istio docs updates #9688

merged 14 commits into from
Feb 4, 2021

Conversation

shlomoartzi
Copy link
Contributor

@shlomoartzi shlomoartzi commented Feb 3, 2021 •
edited
Loading

What does this PR do?

  • updates all Istio-related docs to focus on value (e.g. monitor app health) not features (e.g. collect metrics and logs)
  • section NPM setup requirements so they are easier to parse, and so Istio has a dedicated section

Motivation

  • Istio docs did not present a unified solution
  • NPM setup requirements are spread out

Preview

Replace the branch name and add the complete path: -->
https://docs-staging.datadoghq.com/yael/istio_updates/content/en/network_monitoring/performance/setup.md
https://docs-staging.datadoghq.com/yael/istio_updates/content/en/tracing/setup_overview/proxy_setup/_index.md

Additional Notes

Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Review any mentions of "Contact Datadog support" for internal support documentation.

@shlomoartzi shlomoartzi requested a review from a team as a code owner February 3, 2021 19:56
@github-actions github-actions bot added network_monitoring tracing Content changed in the tracing folder labels Feb 3, 2021
kayayarai
kayayarai requested changes Feb 3, 2021
View reviewed changes
content/en/network_monitoring/performance/setup.md Outdated Show resolved Hide resolved
content/en/network_monitoring/performance/setup.md Outdated Show resolved Hide resolved
content/en/network_monitoring/performance/setup.md Outdated Show resolved Hide resolved
content/en/network_monitoring/performance/setup.md Outdated Show resolved Hide resolved
content/en/tracing/setup_overview/proxy_setup/_index.md Outdated Show resolved Hide resolved
content/en/tracing/setup_overview/proxy_setup/_index.md Outdated Show resolved Hide resolved
shlomoartzi and others added 8 commits February 3, 2021 15:58
@shlomoartzi @kayayarai
Update content/en/network_monitoring/performance/setup.md
4f7554c 
Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com>
@shlomoartzi @kayayarai
Update content/en/network_monitoring/performance/setup.md
84e11d9 
Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com>
@shlomoartzi @kayayarai
Update content/en/network_monitoring/performance/setup.md
3b26435 
Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com>
@shlomoartzi @kayayarai
Update content/en/tracing/setup_overview/proxy_setup/_index.md
1b22d44 
Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com>
@shlomoartzi @kayayarai
Update content/en/network_monitoring/performance/setup.md
3ea722e 
Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com>
@shlomoartzi @kayayarai
Update content/en/tracing/setup_overview/proxy_setup/_index.md
da69ec7 
Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com>
@shlomoartzi
Update NPM Istio link to point to docs, not the blog
6d2cfb5
@shlomoartzi
Fixing nits
15769fc
@shlomoartzi shlomoartzi changed the title Yael/istio updates Yael/istio docs updates Feb 4, 2021
@shlomoartzi shlomoartzi requested a review from kayayarai February 4, 2021 00:09
kayayarai
kayayarai requested changes Feb 4, 2021
View reviewed changes
Copy link
Collaborator

@kayayarai kayayarai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple little things...

content/en/network_monitoring/performance/setup.md Outdated Show resolved Hide resolved
content/en/network_monitoring/performance/setup.md Outdated Show resolved Hide resolved
shlomoartzi and others added 2 commits February 4, 2021 08:42
@shlomoartzi @kayayarai
Update content/en/network_monitoring/performance/setup.md
40a82b3 
Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com>
@shlomoartzi @kayayarai
Update content/en/network_monitoring/performance/setup.md
0382727 
Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com>
@shlomoartzi shlomoartzi requested a review from kayayarai February 4, 2021 16:44
kayayarai
kayayarai approved these changes Feb 4, 2021
View reviewed changes
Copy link
Collaborator

@kayayarai kayayarai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gah, sorry, I missed one link fix -- it works either way, but this is the correct way to do it.

@shlomoartzi @kayayarai
Update content/en/tracing/setup_overview/proxy_setup/_index.md
c62dd34 
Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com>
@kayayarai kayayarai merged commit dc1a01c into master Feb 4, 2021
@kayayarai kayayarai deleted the yael/istio_updates branch February 4, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayayarai kayayarai kayayarai approved these changes

Assignees
No one assigned
Labels
network_monitoring tracing Content changed in the tracing folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shlomoartzi @kayayarai