Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB-975 fix toc scroll, mobile #9162

Merged
merged 1 commit into from
Nov 30, 2020
Merged

WEB-975 fix toc scroll, mobile #9162

merged 1 commit into from
Nov 30, 2020

Conversation

zbayoff
Copy link
Contributor

@zbayoff zbayoff commented Nov 30, 2020

What does this PR do?

  1. Allows TOC to scroll if height is larger than the viewport.
  2. fixes mobile style.

Motivation

https://datadoghq.atlassian.net/jira/software/projects/WEB/boards/102?selectedIssue=WEB-975

Preview

http://docs-staging.datadoghq.com/zach/toc-fix/synthetics/browser_tests/actions/#assertion
https://docs-staging.datadoghq.com/zach/toc-fix/tracing/setup_overview/setup/ruby/#aws
See right TOC, should be scrollable when there are many elements exceeding the viewport height.

@zbayoff zbayoff requested review from a team as code owners November 30, 2020 20:52
@zbayoff zbayoff added the Do Not Merge Just do not merge this PR :) label Nov 30, 2020
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Nov 30, 2020
@zbayoff zbayoff removed the Do Not Merge Just do not merge this PR :) label Nov 30, 2020
@apigirl apigirl merged commit 7fbc81f into master Nov 30, 2020
@apigirl apigirl deleted the zach/toc-fix branch November 30, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants