WEB-883 update ja copy #8886
Merged
WEB-883 update ja copy #8886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbayoff
added
Do Not Merge
|
@zbayoff Looks like the Solutions drop-down is blank.. can you take a look? |
|
@nsollecito sorry, can you post a screen video? I don't see the issue. |
|
this is also happening - https://share.getcloudapp.com/4guJKgb7# |
|
@nsollecito I've fixed the solutions menu. I dont see the issue with the white space under the footer though. |
|
@zbayoff the CTA is still pushing to a second line in the nav and overlapping the body but it's like that on live currently too |
|
@nsollecito yeah this is a known issue, a limitation due to our design. I can try and address in a separate card and get guidance from Brand Design. |
stanleegoodspeed
approved these changes
Oct 23, 2020
apigirl
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
updated Footer copy to match corpsites.
Motivation
https://datadoghq.atlassian.net/jira/software/projects/WEB/boards/102?assignee=5d4b49d50fa6d40d14fc7b11&selectedIssue=WEB-883
Preview
http://docs-staging.datadoghq.com/zach/update-footer-copy