Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split js into exports, lint files #8378

Merged
merged 1 commit into from
Aug 28, 2020
Merged

split js into exports, lint files #8378

merged 1 commit into from
Aug 28, 2020

Conversation

zbayoff
Copy link
Contributor

@zbayoff zbayoff commented Aug 27, 2020

What does this PR do?

  1. makes js functions exportable for future use with code lang selection. Easier to read and manage.
  2. eslint files.
  3. remove old codenav files and deps leftover from old API page.

Motivation

cleanup

Preview link

https://docs-staging.datadoghq.com/zach/js-exportable

Test async functionality, gTag is populating correct value.

@zbayoff zbayoff requested review from a team as code owners August 27, 2020 15:49
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Aug 27, 2020
@nsollecito
Copy link
Collaborator

Separate from this, I noticed the Async nav isn't setup to work on the API pages

@zbayoff
Copy link
Contributor Author

zbayoff commented Aug 28, 2020

Separate from this, I noticed the Async nav isn't setup to work on the API pages

Yeah, it was never ported over after the new API design. It has a different layout, so the async loading would have to be adjusted for it.

Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ruthnaebeck ruthnaebeck merged commit 9072619 into master Aug 28, 2020
@ruthnaebeck ruthnaebeck deleted the zach/js-exportable branch August 28, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants