Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull and extract Go and Java examples #7446

Merged
merged 19 commits into from
May 27, 2020
Merged

Pull and extract Go and Java examples #7446

merged 19 commits into from
May 27, 2020

Conversation

jirikuncar
Copy link
Contributor

@jirikuncar jirikuncar commented May 13, 2020 •
edited
Loading

What does this PR do?

Fetches generated Go and Java examples.

Motivation

Preview link

https://docs-staging.datadoghq.com/jirikuncar/go-examples/api/

Check preview base path using the URL in details in preview status check.

Additional Notes

@jirikuncar jirikuncar requested review from a team as code owners May 13, 2020 16:38
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label May 13, 2020
@jirikuncar jirikuncar changed the title Pull and extract Go examples Pull and extract Go and Java examples May 13, 2020
davidejones
davidejones previously requested changes May 15, 2020
View reviewed changes
Copy link
Member

@davidejones davidejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code examples seem to be leaking some markdown in them too

@jirikuncar jirikuncar requested a review from davidejones May 16, 2020 22:46
@jirikuncar jirikuncar dismissed davidejones’s stale review May 16, 2020 22:47

Updated the rules and made them fail on wrong example format.

@apigirl
Copy link
Contributor

apigirl commented May 18, 2020

I am still seeing the leaked MD in @davidejones example

davidejones
davidejones approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@davidejones davidejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, in the future we might want to move this to the existing pattern / prebuild we have for external dependencies like sec rules, integrations etc.

@github-actions github-actions bot added agent Content changed in the Agent folder FAQ Content impacting a FAQ labels May 27, 2020
@github-actions github-actions bot added integrations Content changed in the integrations folder monitors Content changed in the monitors folder labels May 27, 2020
@apigirl apigirl merged commit a31c31b into master May 27, 2020
@apigirl apigirl deleted the jirikuncar/go-examples branch May 27, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarina-dd sarina-dd sarina-dd approved these changes

@davidejones davidejones davidejones approved these changes

Assignees
No one assigned
Labels
agent Content changed in the Agent folder Architecture Everything related to the Doc backend FAQ Content impacting a FAQ integrations Content changed in the integrations folder monitors Content changed in the monitors folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jirikuncar @apigirl @davidejones @sarina-dd