Skip to content

Update opentelemetry.md #28984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 30, 2025
Merged

Update opentelemetry.md #28984

merged 8 commits into from
Apr 30, 2025

Conversation

mtoffl01
Copy link
Contributor

@mtoffl01 mtoffl01 commented Apr 25, 2025 •
edited
Loading

What does this PR do? What is the motivation?

This PR removes any reference to mapping 128bit Otel trace IDs to Datadog 64bit trace IDs, while still maintaining instructions for mapping Otel span IDs to Datadog span IDs.
This documentation is outdated, as 128bit trace IDs have been supported in the Datadog logs backend [for correlating logs and traces] for quite some time.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@mtoffl01 mtoffl01 mentioned this pull request Apr 25, 2025
Closed
1 task
@github-actions GitHub Actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

janine-c
janine-c approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; thanks again for opening another PR! When you're ready to merge, you'll need to take it out of draft mode (I think by marking it as ready for review), and then you can comment /merge to add it to our merge queue. Let us know if you need anything else!

@mtoffl01 @janine-c
Update content/en/tracing/other_telemetry/connect_logs_and_traces/ope…
a722246 
…ntelemetry.md

Co-authored-by: Janine Chan <64388808+janine-c@users.noreply.github.com>
@dd-devflow
Copy link

dd-devflow bot commented Apr 28, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-04-28 17:50:04 UTC ℹ️ Start processing command /merge

2025-04-28 17:50:11 UTC ❌ MergeQueue

This PR is a draft

@mtoffl01 mtoffl01 marked this pull request as ready for review April 28, 2025 17:50
@mtoffl01 mtoffl01 requested a review from a team as a code owner April 28, 2025 17:50
iadjivon
iadjivon approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@iadjivon iadjivon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
When you're ready to merge, comment /merge to add it to our merge queue. Let us know if you need anything else!

@iadjivon
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 28, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-04-28 22:10:37 UTC ℹ️ Start processing command /merge

2025-04-28 22:10:41 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 20m (p90).

2025-04-28 22:11:20 UTC ⚠️ MergeQueue: This merge request build was cancelled

ida.adjivon@datadoghq.com cancelled this merge request build

@iadjivon
Copy link
Contributor

/merge -c

@dd-devflow
Copy link

dd-devflow bot commented Apr 28, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-04-28 22:11:13 UTC ℹ️ Start processing command /merge -c

@iadjivon
Copy link
Contributor

Accidentally started the merge, but realize it was not marked as ready to merge.
This is ready for merge when you are ready.

@mtoffl01
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 30, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-04-30 20:04:13 UTC ℹ️ Start processing command /merge

2025-04-30 20:04:20 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 20m (p90).

2025-04-30 20:20:09 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 9b3771c into master Apr 30, 2025
21 of 26 checks passed
@dd-mergequeue dd-mergequeue bot deleted the mtoff/otel-logs-traces branch April 30, 2025 20:20
aldrickdev pushed a commit that referenced this pull request May 7, 2025
@mtoffl01 @mabdinur
Update opentelemetry.md (#28984)
70534eb 
Co-authored-by: mabdinur <munir.abdinur@datadoghq.com>
estherk15 pushed a commit that referenced this pull request May 8, 2025
@mtoffl01 @mabdinur @estherk15
Update opentelemetry.md (#28984)
677dc61 
Co-authored-by: mabdinur <munir.abdinur@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janine-c janine-c janine-c approved these changes

@iadjivon iadjivon iadjivon approved these changes

Assignees
No one assigned
Labels
mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mtoffl01 @iadjivon @janine-c @mabdinur