Skip to content

[AZINTS-3246] replace the old blob forwarder with the new one #28536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

ava-silver
Copy link
Contributor

@ava-silver ava-silver commented Apr 2, 2025

What does this PR do? What is the motivation?

We've created a v2 of the Blob Storage-based log forwarder, which is strictly better than the old one. This PR updates the docs to point to that one, and improves the installation instructions.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@ava-silver ava-silver requested a review from a team as a code owner April 2, 2025 20:46
@github-actions github-actions bot added the Guide Content impacting a guide label Apr 2, 2025
Copy link
Contributor

github-actions bot commented Apr 2, 2025

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@estherk15 estherk15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs! Left some suggestions for clarity and information formatting. Let me know if you have any questions!


##### Add a new function to your Function App using the Azure Blob Storage trigger template
For each resource which you would like to [forward resource logs][304], when viewing the resource in the Azure portal, under **Monitoring**, select **Diagnostic settings**. Create a new diagnostic setting, select all the categories you would like to forward, and under **Destination details**, select **Archive to a storage account**, and enter the details of the storage account just created.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For each resource which you would like to [forward resource logs][304], when viewing the resource in the Azure portal, under **Monitoring**, select **Diagnostic settings**. Create a new diagnostic setting, select all the categories you would like to forward, and under **Destination details**, select **Archive to a storage account**, and enter the details of the storage account just created.
To [forward resource logs][304] for a resource, open the resource in the Azure portal. Under **Monitoring**, select **Diagnostic settings**. Create a new diagnostic setting, select the categories you want to forward, and under **Destination details**, select **Archive to a storage account**. Then enter the details of the storage account you just created.

@ava-silver ava-silver requested a review from mattsp1290 April 3, 2025 14:35

Datadog recommends using the Event Hub setup for Azure log collection. However, you can also follow the steps in this section to forward all of your Azure App Services logs from Azure Blob Storage:
**Note**: Resources can only send logs to storage accounts in the same Azure region.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This note should be closer to the diagnostic settings setup

Copy link
Contributor Author

@ava-silver ava-silver Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that at first, but it matters when they are deploying, since otherwise a customer could deploy and then realize that it isnt in the correct region. Maybe it makes sense to add that info to the diagnostic setting section as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Event Hub forwarder has this same restriction. In the docs, this is at the end of the deployment section immediately before discussing adding diagnostic settings. Maybe just moving lower so it is still near deployment but also near diagnostic settings.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also just swap the places of the two notes

@ava-silver
Copy link
Contributor Author

Caution

DO NOT MERGE

We're holding off on merging these changes until we have a good idea of what the whole azure logging docs page should look like.

@ava-silver ava-silver added the Do Not Merge Just do not merge this PR :) label Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge Just do not merge this PR :) Guide Content impacting a guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants