Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedded Collector Pre-Release Updates #27854

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Embedded Collector Pre-Release Updates #27854

wants to merge 9 commits into from

Conversation

brett0000FF
Copy link
Contributor

@brett0000FF brett0000FF commented Feb 26, 2025 •
edited
Loading

What does this PR do? What is the motivation?

  • Added support level information.
  • Added region-specific FedRAMP/FIPS compliance notice for us1-fed.
  • Added clarification that custom Agent images need to be stored in private repositories and that the build process must be repeated for each Agent version update.
  • Added notes about potential differences in default configuration between Datadog's embedded collector and standalone OpenTelemetry Collector
  • Added verification step due to migration guide to check for changed metric names.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@brett0000FF brett0000FF requested a review from a team as a code owner February 26, 2025 23:09
@brett0000FF brett0000FF marked this pull request as draft February 26, 2025 23:10
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 26, 2025 •
edited
Loading

Preview links (active after the build_preview check completes)

Modified Files

@brett0000FF brett0000FF requested review from LutaoX and rpsqrd February 26, 2025 23:40
LutaoX
LutaoX reviewed Mar 3, 2025
View reviewed changes
content/en/opentelemetry/agent/_index.md
@@ -11,6 +11,10 @@ further_reading:
The Datadog Agent with embedded OpenTelemetry Collector is in Preview. To request access, fill out this form.
{{< /callout >}}

{{< site-region region="gov" >}}
<div class="alert alert-danger"><strong>The Datadog Agent with embedded OpenTelemetry Collector is not FedRAMP or FIPS compliant.</strong><br> FedRAMP customers should not use the embedded OpenTelemetry Collector and should continue using standard Agent deployments.</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"FedRAMP customers should not use the embedded OpenTelemetry Collector and should continue using standard Agent deployments."

I would rephrase this to be:
FedRAMP customers should not enable or use the embedded OpenTelemetry Collector.

This is because Otel Collector is part of the Agent. If we refer it the Agent without Otel Collector as "standard Agent" , it creates a misunderstanding that Agent with Otel is a different flavor of Agent. Within 1 or 2 quarters, all Agent image will be revamped.

LutaoX
LutaoX reviewed Mar 3, 2025
View reviewed changes
content/en/opentelemetry/agent/_index.md Outdated

- **Fully Supported Components**: Datadog-owned components such as the [Datadog Connector][44], [Datadog Exporter][38], and [Infra Attribute Processor][50]. These components are fully maintained by Datadog, receive regular updates, and are prioritized for bug fixes and feature enhancements.

- **Community Supported Components**: Standard OpenTelemetry components included with the Agent by default. Datadog ensures these components are secure, stable, and compatible with the Agent. While Datadog provides assistance with configuration and usage, feature development and enhancements for these components are managed through the OpenTelemetry community.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Standard OpenTelemetry components included with Agent"

Can we rephrase it to below?
"OpenTelemetry components included with Agent (see list)"

  1. remove the word "standard"
  2. add " (see list)" and add a hyperlink to the "list" to direct users to check what list of components we are referring to.
  • Alternatively, we can directly add the hyperlink to "OpenTelemetry Components"

LutaoX
LutaoX reviewed Mar 3, 2025
View reviewed changes
content/en/opentelemetry/agent/agent_with_custom_components.md Outdated
@@ -201,6 +207,8 @@ You can now use this new image to install the Agent. This enables Datadog monito

For detailed instructions on installing and configuring the Agent with added OpenTelemetry components, see the [Install the Datadog Agent with Embedded OpenTelemetry Collector][9] guide.

<div class="alert alert-info">The default configuration settings in Datadog's embedded collector may differ from the standard OpenTelemetry Collector configuration defaults. This can affect behavior of components like the <code>filelogreceiver</code>. Review the configuration closely when migrating from a standalone collector.</div>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this section should be on a different page: e.g. either a troubleshooting guide for "migrating to the DD agent with embedded OTel Collector" or a separate troubleshooting FAQ page, where we consolidate everything there. Will follow up via Slack thread.

LutaoX
LutaoX reviewed Mar 3, 2025
View reviewed changes
content/en/opentelemetry/agent/migration.md Outdated
@@ -375,6 +375,8 @@ After configuring your application, verify that data is flowing correctly to Dat
kubectl apply -f deployment.yaml
```
1. Confirm that telemetry data is being received in your Datadog account. Check logs, traces and metrics to ensure correct data collection and correlation.
1. Review your dashboards and monitors to ensure they reference the correct metric names, as some metric names may change when migrating from a standalone OpenTelemetry Collector to the Datadog Agent with embedded Collector.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is not needed anymore, since we kept the logic the same between Collector OSS and Agent with embedded Collector.

@github-actions github-actions bot added the Images Images are added/removed with this PR label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LutaoX LutaoX LutaoX left review comments

@rpsqrd rpsqrd Awaiting requested review from rpsqrd

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Images Images are added/removed with this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brett0000FF @LutaoX