Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update validating-service-definition.md #27462

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

dgreen15
Copy link
Contributor

@dgreen15 dgreen15 commented Feb 5, 2025

What does this PR do? What is the motivation?

The image seems to be broken because video was set to true. Would appreciate some validation that this would fix the issue.

Merge instructions

Merge readiness:

  • [ x] Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@dgreen15 dgreen15 requested a review from a team as a code owner February 5, 2025 15:59
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Preview links (active after the build_preview check completes)

Modified Files

@dgreen15
Copy link
Contributor Author

dgreen15 commented Feb 5, 2025

The preview seems like it may still not be rendering the image correctly, but I'm not sure what the issue is. Any help would be appreciated.

…tion.md

Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com>
Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Image is rendering on the page as expected..

@drichards-87
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 5, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-02-05 18:01:50 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 7m.


2025-02-05 18:09:36 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 94f98f8 into master Feb 5, 2025
16 of 18 checks passed
@dd-mergequeue dd-mergequeue bot deleted the dgreen15/fixing-broken-image branch February 5, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants