Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Free and Full Text Search documentation #27434

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

piotr-oles
Copy link
Contributor

Hi! I'm Piotr and I'm part of the #frontend-parser-guild.

What does this PR do? What is the motivation?

I found a few mistakes in the free and full-text search documentation. I consulted this with @sfluor from EvP storage and tested provided examples on org 2.

Merge instructions

The feature is GA'd nothing blocking here.

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Hi! I'm Piotr and I'm part of the #frontend-parser-guild. I found a few mistakes in the free and full-text search documentation. I consulted this with @sfluor from EvP storage and tested provided examples on org 2.
@piotr-oles piotr-oles requested a review from a team as a code owner February 4, 2025 09:54
@piotr-oles piotr-oles requested a review from sfluor February 4, 2025 09:54
| `hello` | Free text | Searches only the log message for the term `hello`. |
| Search syntax | Search type | Description |
| ------------- | ----------- | --------------------------------------------------------- |
| `*:hello` | Full-text | Searches all log attributes for the exact string `hello`. |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe use the same wording for both (exact string / word)

Copy link

@sfluor sfluor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ! thanks for doing this !

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Preview links (active after the build_preview check completes)

Modified Files

| Search syntax | Search type | Description |
| ------------- | ----------- | ------------------------------------------------------------------------------------------- |
| `*:hello` | Full-text | Searches all log attributes for the exact string `hello`. |
| `*:hello*` | Full-text | Searches all log attributes for strings starting with `hello`. For example, `hello_world`. |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a ticket (https://datadoghq.atlassian.net/browse/DOCS-9144) that removed starting from this description after customer reported it's matching all logs with hello word inside it. I tested it on org 2 and it's not the case. I think customer got confused in some way, but they report was not valid.

Comment on lines -71 to -77
### Multiple terms without exact match example

The full-text search syntax `*:hello world` is equivalent to `*:hello *:world`. It searches all log attributes for the terms `hello` and `world`.

### Multiple terms with a white space example

The full-text search syntax `*:"hello world" "i am here"` is equivalent to `*:"hello world" *:"i am here"`. It searches all log attributes for the terms `hello world` and `i am here`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These paragraphs were not true. It's better to remove them :)
For example *:hello world is not equal to *:hello *:world. In this example, we will do Full Text Search on hello and Free Text Search on world. Same goes with the second paragraph.

Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small suggestion from Docs.

content/en/logs/explorer/search_syntax.md Outdated Show resolved Hide resolved
Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com>
@drichards-87
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 5, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-02-05 20:09:36 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 7m.


2025-02-05 20:18:20 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 31e0185 into master Feb 5, 2025
16 of 18 checks passed
@dd-mergequeue dd-mergequeue bot deleted the piotr-oles/update-text-search-documentation branch February 5, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants