Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade nodejs version #27401

Conversation

ava-silver
Copy link
Contributor

@ava-silver ava-silver commented Jan 31, 2025

What does this PR do? What is the motivation?

Update the NodeJS version in the azure log forwarder deployment docs. Node 18 is being deprecated soon. We already successfully tested the forwarder with Node 20. Previously we updated but found a problem, which has now been fixed.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@github-actions github-actions bot added the Guide Content impacting a guide label Jan 31, 2025
Copy link
Contributor

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ava-silver ava-silver changed the title Upgrade nodejs version (take 2) Upgrade nodejs version Jan 31, 2025
@ava-silver ava-silver marked this pull request as ready for review January 31, 2025 21:57
@ava-silver ava-silver requested a review from a team as a code owner January 31, 2025 21:57
@cswatt
Copy link
Contributor

cswatt commented Jan 31, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 31, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-31 22:04:37 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 7m.


2025-01-31 22:13:30 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 399e581 into master Jan 31, 2025
18 of 19 checks passed
@dd-mergequeue dd-mergequeue bot deleted the revert-27362-revert-27260-rebecca.parsons/upgrade_nodejs_version_azure_log_forwarder branch January 31, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Guide Content impacting a guide mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants