Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _index.md | make it clearer that facets value include restricted tests #27399

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

AlaricCalmette
Copy link
Contributor

What does this PR do? What is the motivation?

Update index.md to make it clearer that facets values might come from test the user doesn't have access to.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@AlaricCalmette AlaricCalmette requested a review from a team as a code owner January 31, 2025 15:26
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AlaricCalmette thanks for the update, just a couple small suggestions.

content/en/synthetics/explore/_index.md Outdated Show resolved Hide resolved
content/en/synthetics/explore/_index.md Outdated Show resolved Hide resolved
Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>
Copy link
Contributor

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! please add a comment with /merge when this is ready to be merged.

@AlaricCalmette
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 3, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-02-03 15:53:59 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 7m.


2025-02-03 16:01:15 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 08ce919 into master Feb 3, 2025
17 of 20 checks passed
@dd-mergequeue dd-mergequeue bot deleted the alaric/VULN-7524/restricted-test-facet-value branch February 3, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants