Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use underscore instead of dash for Kotlin Multiplatform pages naming #27377

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Jan 30, 2025

What does this PR do? What is the motivation?

This PR brings a change of all kotlin-multiplatform page references to kotlin_multiplatform to align with overall naming style.

Current usage of kotlin-multiplatform has issues, for example this page (with kotlin_multiplatform) references this one (with kotlin-multiplatform), which doesn't exist.

I also kept old page aliases to have correct links from search engines.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@0xnm 0xnm requested review from a team as code owners January 30, 2025 16:34
Copy link
Contributor

Preview links (active after the build_preview check completes)

Renamed files

Modified Files

@0xnm 0xnm force-pushed the nogorodnikov/use-underscore-instead-of-dash-for-kotlin-multiplatform-pages branch from c578f59 to c753576 Compare January 30, 2025 17:21
@0xnm 0xnm requested review from a team as code owners January 30, 2025 17:21
@github-actions github-actions bot added Architecture Everything related to the Doc backend Github Related to Github configurations labels Jan 30, 2025
@rtrieu
Copy link
Contributor

rtrieu commented Jan 30, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 30, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-30 20:55:34 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-30 21:34:09 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in master is 7m.


2025-01-30 21:40:04 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit d9b496f into master Jan 30, 2025
21 of 26 checks passed
@dd-mergequeue dd-mergequeue bot deleted the nogorodnikov/use-underscore-instead-of-dash-for-kotlin-multiplatform-pages branch January 30, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend Github Related to Github configurations mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants