DOCS-9940: Serverless Monitoring for Azure Functions#27294
Conversation
Preview links (active after the
|
duncanpharvey
left a comment
duncanpharvey
left a comment
There was a problem hiding this comment.
Thanks for getting this started @cswatt! Let me know what you think about my suggestions.
Can we mention that we support runtime metrics and custom metrics and link the relevant documentation?
- https://docs.datadoghq.com/tracing/metrics/runtime_metrics/python/
- https://docs.datadoghq.com/tracing/metrics/runtime_metrics/nodejs
- https://docs.datadoghq.com/metrics/custom_metrics/dogstatsd_metrics_submission/
Could we also have more section (maybe under troubleshooting?) to document that if deploying to a Linux Consumption function with a Github Action that the "Using Azure Service Principal for RBAC as Deployment Credential" method needs to be used?
Co-authored-by: Duncan Harvey <35278470+duncanpharvey@users.noreply.github.com>
cswatt
added
editorial review
Co-authored-by: Duncan Harvey <35278470+duncanpharvey@users.noreply.github.com>
janine-c
left a comment
janine-c
left a comment
There was a problem hiding this comment.
Looks great, Cecilia! I noticed a couple things, mostly questions I had based on not being familiar with how the code works 😅 Let me know when you'd like me to take a final look, and/or if there's anything else I can help you out with!
| {{< /programming-lang >}} | ||
| {{< /programming-lang-wrapper >}} | ||
|
|
||
| 3. **Deploy your function**. |
There was a problem hiding this comment.
The numbering goes back to 3 here - just bump the numbers from here on in up by 2 and you're good to go 🙂
| 4. (Optional) **Enable custom metrics**. See [Metric Submission: DogStatsD][3]. | ||
| [1]: /tracing/trace_collection/automatic_instrumentation/?tab=singlestepinstrumentation |
There was a problem hiding this comment.
I don't know if you saw this during your testing or if it's something odd going on on my end, but my local build insists on having this blank line to render the links properly:
| 4. (Optional) **Enable custom metrics**. See [Metric Submission: DogStatsD][3]. | |
| [1]: /tracing/trace_collection/automatic_instrumentation/?tab=singlestepinstrumentation | |
| 4. (Optional) **Enable custom metrics**. See [Metric Submission: DogStatsD][3]. | |
| [1]: /tracing/trace_collection/automatic_instrumentation/?tab=singlestepinstrumentation |
| 5. **Configure Unified Service Tagging**. You can collect metrics from your Azure Functions by installing the [Datadog Azure integration][6]. To correlate these metrics with your traces, first set the `env`, `service`, and `version` tags on your resource in Azure. Then, configure the following environment variables. You can add custom tags as `DD_TAGS`. | ||
|
|
||
| ``` | ||
| DD_ENV="<ENVIRONMENT>" |
There was a problem hiding this comment.
Just want to double check that these environment variables use quotation marks, but the ones in the previous step don't?
There was a problem hiding this comment.
So it's actually an interface that they'd use to add each of these... you bring up a good point, I'm going to reformat this
janine-c
left a comment
janine-c
left a comment
There was a problem hiding this comment.
Looks great! I find the environment variables a lot easier to scan in a table ✨
|
/merge |
|
View all feedbacks in Devflow UI.
The median merge time in
|
dd-devflow
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
4 participants
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/descriptionnaming convention) and then add the following PR comment:Additional notes