-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add doc for automatic user ID collection modes and remote-config #23871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Preview links (active after the
|
b22224e
to
fa05ac8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. We should get rid of before x
in two places, and mention why people might want to turn the feature off (or rather - why they shouldn't). Added the appropriate suggestions.
@@ -712,6 +712,8 @@ The events that can be automatically detected are: | |||
|
|||
### Automatic user activity event tracking mode | |||
|
|||
<div class="alert alert-warning"><strong>This is deprecated</strong> and only applies to older agent versions before x</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before x
- we should link to the compatibility page here: https://docs.datadoghq.com/security/application_security/enabling/compatibility/
As the version depends per-library, we can't list all of them here.
**Note**: There could be cases in which the trace library won't be able to extract any information from the user event. The event would be reported with empty metadata. In those cases, we recommend using the [SDK](#adding-business-logic-information-login-success-login-failure-any-business-logic-to-traces) to manually instrument the user events. | ||
|
||
## Disabling automatic user activity event tracking | ||
|
||
<div class="alert alert-warning"><strong>This is deprecated</strong> and only applies to older agent versions before x</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above - before x
(suggest to link to the compatibility page)
content/en/security/application_security/threats/add-user-info.md
Outdated
Show resolved
Hide resolved
Note: we should not merge this until we have the green light from @Julio-Guerra that the feature is available and the corresponding compatibility page is updated. |
What does this PR do? What is the motivation?
Merge instructions
Additional notes