Skip to content

[WEB-4947] Migrates all marketplace integrations to be sourced from APW #23697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

bgdeutsch
Copy link
Collaborator

@bgdeutsch bgdeutsch commented Jun 14, 2024

What does this PR do? What is the motivation?

Sources all marketplace integrations from APW/websites-sources
Removes all code related to marketplace integration processing from the Docs build

Merge instructions

  • Please merge after websites reviews

Additional notes

Check all marketplace integrations. All marketplace tiles should continue to surface on the list page, and all details pages should match whats in live.

https://docs-staging.datadoghq.com/brian.deutsch/all-the-marketplace-integrations/integrations/#cat-marketplace

Check all existing integrations to make sure they are still being processed correctly.

https://docs-staging.datadoghq.com/brian.deutsch/all-the-marketplace-integrations/integrations

Signed-off-by: Brian Deutsch <brian.deutsch@datadoghq.com>
Signed-off-by: Brian Deutsch <brian.deutsch@datadoghq.com>
Signed-off-by: Brian Deutsch <brian.deutsch@datadoghq.com>
Signed-off-by: Brian Deutsch <brian.deutsch@datadoghq.com>
@bgdeutsch bgdeutsch added the Do Not Merge Just do not merge this PR :) label Jun 14, 2024
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Jun 14, 2024
Signed-off-by: Brian Deutsch <brian.deutsch@datadoghq.com>
Copy link
Contributor

@StefonSimmons StefonSimmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -1,6 +1,6 @@
---
- config:
cache_enabled: true
cache_enabled: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cache_enabled: false
cache_enabled: true

Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local / preview builds look good! I left a comment in the Slack thread about some missing integrations

@@ -67,9 +67,6 @@ content/en/integrations/guide/amazon_cloudformation.md
!content/en/integrations/snyk.md
!content/en/integrations/content_security_policy_logs.md

# Ignore the marketplace images that get pulled
static/images/marketplace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to leave this in here for a while until everyone has had a chance to run a clean.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea this is a good point can we postpone this change @bgdeutsch

Signed-off-by: Brian Deutsch <brian.deutsch@datadoghq.com>
Signed-off-by: Brian Deutsch <brian.deutsch@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend Do Not Merge Just do not merge this PR :)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants