Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS-7981] Add Datadog Agent source to log volume control #23226

Merged
merged 2 commits into from
May 23, 2024

Conversation

maycmlee
Copy link
Contributor

@maycmlee maycmlee commented May 16, 2024

What does this PR do? What is the motivation?

Adds the Datadog Agent source page for the Log Volume Control use case. The doc uses mostly existing general reuse shortcodes so there isn't a lot of new content to review.

DOCS-7981

Merge instructions

  • Please merge after reviewing

Additional notes

@maycmlee maycmlee requested a review from a team as a code owner May 16, 2024 18:13
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label May 16, 2024
Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! I like how you laid this out. All of the shortcodes made this easy to review. I checked the preview to make sure nothing funky was happening too.

@p-parekh
Copy link
Contributor

May, I am wondering if we should move the "Connect your DD agent to OP" section ahead of setting up the destinations? Currently we talk about setting up source->dest->source. I am proposing setting up source completely before moving to destination. Thoughts?

@maycmlee
Copy link
Contributor Author

May, I am wondering if we should move the "Connect your DD agent to OP" section ahead of setting up the destinations? Currently we talk about setting up source->dest->source. I am proposing setting up source completely before moving to destination. Thoughts?

@p-parekh I'm pretty sure I brought this up when we were getting the OP 2.0 docs ready for the launch and Barry and Eugene said it makes more sense for that section to be at the end because users are going through the UI to build the pipeline first. After the pipeline is ready, then they should start sending logs to it.

@maycmlee maycmlee merged commit c40c406 into master May 23, 2024
19 checks passed
@maycmlee maycmlee deleted the may/add-dd-agent-to-lvc branch May 23, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants