Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CWS setup instructions for host based installation #17598

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update CWS setup instructions for host based installation #17598

wants to merge 2 commits into from

Conversation

lebauce
Copy link
Contributor

@lebauce lebauce commented Apr 6, 2023

What does this PR do?

Motivation

Additional Notes

Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Check images for PII
  • Review any mentions of "Contact Datadog support" for internal support documentation.

@lebauce lebauce requested a review from a team as a code owner April 6, 2023 15:54
@lebauce lebauce force-pushed the lebauce/update-cws-setup-instructions branch 2 times, most recently from 8ea734c to aa4d4be Compare April 6, 2023 16:04
maycmlee
maycmlee reviewed Apr 6, 2023
View reviewed changes
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedback! Also, could merge in master? Looks like your preview build is breaking, so hopefully that will fix it.

content/en/security/cloud_workload_security/getting_started.md Outdated Show resolved Hide resolved
content/en/security/cloud_workload_security/getting_started.md Outdated Show resolved Hide resolved
content/en/security/cloud_workload_security/getting_started.md Outdated Show resolved Hide resolved
content/en/security/cloud_workload_security/getting_started.md Outdated Show resolved Hide resolved
content/en/security/cloud_workload_security/getting_started.md Outdated Show resolved Hide resolved
content/en/security/cloud_workload_security/getting_started.md Outdated Show resolved Hide resolved
content/en/security/cloud_workload_security/getting_started.md Outdated Show resolved Hide resolved
content/en/security/cloud_workload_security/getting_started.md Outdated Show resolved Hide resolved
content/en/security/cloud_workload_security/getting_started.md Outdated Show resolved Hide resolved
@lebauce lebauce force-pushed the lebauce/update-cws-setup-instructions branch from aa4d4be to 010203e Compare April 7, 2023 10:31
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

Preview links (active after the build_preview check completes)

Modified Files

@lebauce lebauce requested a review from maycmlee April 7, 2023 10:50
@maycmlee
Copy link
Contributor

maycmlee commented Apr 7, 2023

Thanks @lebauce for opening this PR! Is this good to merge?

@lebauce
Copy link
Contributor Author

lebauce commented Apr 7, 2023

@maycmlee I'll ask a last review of someone from the team to recheck that the specified instructions work as expected

@lebauce lebauce force-pushed the lebauce/update-cws-setup-instructions branch from 010203e to 9800903 Compare April 13, 2023 07:39
@lebauce lebauce requested a review from maycmlee April 14, 2023 15:45
maycmlee
maycmlee approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lebauce LGTM! The FR/JA translations may not persist because the change needs to be made in our translation pipelines. Ready to merge?

@lebauce lebauce force-pushed the lebauce/update-cws-setup-instructions branch 5 times, most recently from 0011f3d to c788983 Compare April 25, 2023 14:09
@lebauce lebauce force-pushed the lebauce/update-cws-setup-instructions branch from c788983 to 5206956 Compare June 29, 2023 13:19
@maycmlee
Copy link
Contributor

maycmlee commented Oct 4, 2023

@lebauce wanted to check in again to see if this is good to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spikat spikat spikat approved these changes

@maycmlee maycmlee maycmlee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lebauce @maycmlee @spikat