-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brooklyne.finni/accessibility #17064
Open
brooklynebkbk
wants to merge
9
commits into
master
Choose a base branch
from
brooklyne.finni/accessibility
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgdeutsch
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirming there are 0 a11y errors on the authn_mapping
page now. tab functionality still looks good as well. 👍
Created DOCS-5057 for the Docs team review. |
@brooklynebkbk Quick question. Is there anything in this PR that you'd like the Docs team to test? |
drichards-87
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Architecture
Everything related to the Doc backend
editorial review
Waiting on a more in-depth review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates Code Tab and Code Lang Tab links and content in an effort to make tab content more accessible
aria-role
andaria-label
attributes to list of tabsaria-role
andaria-controls
attributes to clickable list itemsid
value to tab content/panel - corresponding with the clickable list item'saria-controls
valueMotivation
https://datadoghq.atlassian.net/browse/WEB-2432
https://docs-staging.datadoghq.com/brooklyne.finni/accessibility/
Changes to the
layouts/shortcodes/tab.html
, layouts/shortcodes/tabs.html
,assets/scripts/components/codetabs.js
files can be observed on any pages that use the tabs shortcodeex: https://docs-staging.datadoghq.com/brooklyne.finni/accessibility/account_management/authn_mapping/?tab=example
and changes to the
layouts/shortcodes/programming-lang.html
andlayouts/partials/code-lang-tabs.html
can be observed on api pages with tabbed contentex: https://docs-staging.datadoghq.com/brooklyne.finni/accessibility/api/latest/
Additional Notes
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-controls
Reviewer checklist