Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommend using localhost on host installs for OTLP ingest #15438

Merged
merged 2 commits into from
Oct 11, 2022
Merged

Recommend using localhost on host installs for OTLP ingest #15438

merged 2 commits into from
Oct 11, 2022

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Sep 30, 2022

What does this PR do?

Changes recommendations for OTLP ingest endpoint on local installs to recommend using localhost.

Motivation

Follow recommendations proposed over at open-telemetry/opentelemetry-collector/issues/6151.

Additional Notes

Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Check images for PII
  • Review any mentions of "Contact Datadog support" for internal support documentation.

@mx-psi mx-psi requested a review from a team as a code owner September 30, 2022 18:57
@github-actions github-actions bot added the tracing Content changed in the tracing folder label Sep 30, 2022
@github-actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@mx-psi mx-psi requested a review from a team September 30, 2022 18:59
@mx-psi
Copy link
Member Author

mx-psi commented Oct 10, 2022 •
edited
Loading

@hestonhoffman This is good to merge let's wait for the Otel team

dineshg13
dineshg13 approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@dineshg13 dineshg13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hestonhoffman hestonhoffman merged commit 74b6046 into master Oct 11, 2022
@hestonhoffman hestonhoffman deleted the mx-psi/otlp-recommendations branch October 11, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hestonhoffman hestonhoffman hestonhoffman approved these changes

@dineshg13 dineshg13 dineshg13 approved these changes

Assignees
No one assigned
Labels
tracing Content changed in the tracing folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mx-psi @dineshg13 @hestonhoffman