added way to specify platform specific metrics #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I like this idea but I don't think front matter is the place for it. This metadata needs to be in metadata.csv along with the rest of the metadata. Recently, I've just been cramming extra metadata into the description field, but at some point soon, we should coordinate with whomever owns metrics metadata to get some new fields (i.e. columns) added. |
|
getting it into metadata is a good next step, but there are lots of things that have been tried to get into the metadata for a long time and its not there yet. I think we need a good interim step and this is a good place for it. Lets get something working to get past the support calls now and get something better for the long term later on. |
|
Fair enough, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add platformmetrics to the frontmatter and then the metric name followed by a list of platforms you can find that metric on and the metric name in the table will be followed by **platform only where platform is the name of the platform. If you specify Windows and Solaris, it will say **Windows and Solaris only. If you have more than 2 platform, it puts the commas in the right way.
I added the metrics for disk and network that were mentioned in the card. But I am sure there are others.