Add TraceWriter and AsyncTraceWriter workers #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
core
delner
commented
Mar 30, 2020
|
|
||
| # Writes traces to transport asynchronously, | ||
| # using a thread & buffer. | ||
| class AsyncTraceWriter < TraceWriter |
There was a problem hiding this comment.
Should I move this to its own file? Was useful seeing both of these together, but it might make sense to have one class per file whenever possible/reasonable.
There was a problem hiding this comment.
I don't see a problem with having them both in this file right now, specially since one inherits from the other, making navigating the implementation of AsyncTraceWriter easier.
If sync and async implementation become more divergent we could move them to separate files with little hassle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #879
This pull request adds the
Datadog::Workers::TraceWriterandDatadog::Workers::AsyncTraceWriterclasses, which act as replacements for theDatadog::Writerclass.TraceWriteris the base class for trace writing and defines how traces are written to a transport; it's analogous toSyncWriterand replaces it.AsyncTraceWriterextendsTraceWriter, decorating it with asynchronous behaviors that allows the same trace writing behavior to execute in its own worker thread on a polling basis. It will replaceDatadog::Writerand theAsyncTransport.Once in place, the goal is to have these workers act as drop-in replacements for the writer, then eventually phase out/remove the
WriterandAsyncTransportentirely, in a future PR.