Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: ensure http.status_code tag is always a string #927

Merged
merged 4 commits into from
Jan 16, 2020
Merged

core: ensure http.status_code tag is always a string #927

merged 4 commits into from
Jan 16, 2020

Conversation

brettlangdon
Copy link
Member

The agent explicitly looks for Span.meta['http.status_code'] we need to ensure that http.status_code is always added to @meta as a string.

@brettlangdon brettlangdon requested a review from a team January 16, 2020 15:58
marcotc
marcotc approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 as a solution to ensure backwards compatibility with all supported version of the agent.

This is definitely something we'd like to clean up in the future.

@brettlangdon brettlangdon merged commit be9b86d into master Jan 16, 2020
@brettlangdon brettlangdon deleted the brettlangdon/http.status_code branch January 16, 2020 19:07
marcotc pushed a commit that referenced this pull request Jan 16, 2020
@brettlangdon @marcotc
core: ensure http.status_code tag is always a string (#927)
0238a83 
* core: ensure http.status_code tag is always a string

* rubocop fix

* fix Span#set_tag test cases

* fix ethon test
@marcotc marcotc mentioned this pull request Jan 16, 2020
Merged
@marcotc marcotc added the core Involves Datadog core libraries label Jan 16, 2020
@marcotc marcotc added this to the 0.31.1 milestone Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcotc marcotc marcotc approved these changes

Assignees
No one assigned
Labels
core Involves Datadog core libraries
Projects
None yet
Milestone
0.31.1
Development

Successfully merging this pull request may close these issues.
2 participants
@brettlangdon @marcotc