Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default RuleSampler rate_limit of 100 #898

Merged
merged 2 commits into from
Jan 2, 2020
Merged

Set default RuleSampler rate_limit of 100 #898

merged 2 commits into from
Jan 2, 2020

Conversation

brettlangdon
Copy link
Member

We want to default to 100 traces per second by default as a safety mechanism for high volume customers.

@brettlangdon brettlangdon requested a review from a team December 27, 2019 18:08
delner
delner reviewed Dec 31, 2019
View reviewed changes
Copy link
Contributor

@delner delner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One minor suggestion.

lib/ddtrace/sampling/rule_sampler.rb Outdated Show resolved Hide resolved
@brettlangdon
Copy link
Member Author

Updated to use a constant

@brettlangdon brettlangdon merged commit 53bf0e4 into master Jan 2, 2020
@brettlangdon brettlangdon deleted the brettlangdon/default.rate.limit branch January 2, 2020 19:22
@marcotc marcotc added this to the 0.31.0 milestone Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delner delner delner left review comments

@marcotc marcotc marcotc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.31.0
Development

Successfully merging this pull request may close these issues.
3 participants
@brettlangdon @marcotc @delner