Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Rails version incompatible with Ruby 2.2 #894

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Dec 19, 2019

The latest version of Rails 5.2, Rails 5.2.4.1, contains a bug when running uner Ruby 2.2: it is using syntax that is only available for Ruby 2.3 and above: rails/rails@92f660b#diff-0dd82841c763273551965fc0ea292a1bR96

This PR prevents us from installing this patch release of Rails for Ruby 2.2, in order to unblock our CI pipeline.

@marcotc marcotc added the dev/testing Involves testing processes (e.g. RSpec) label Dec 19, 2019
@marcotc marcotc requested a review from a team December 19, 2019 23:48
@marcotc marcotc self-assigned this Dec 19, 2019
Copy link
Contributor

@delner delner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marcotc marcotc merged commit b246842 into master Dec 20, 2019
@marcotc marcotc deleted the test/tmp-lock-rails-for-ruby-2.2 branch December 20, 2019 18:50
@delner delner mentioned this pull request Dec 30, 2019
@marcotc marcotc added this to the 0.31.0 milestone Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants