Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dalli multiplexing #823

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Dalli multiplexing #823

merged 1 commit into from
Oct 1, 2019

Conversation

delner
Copy link
Contributor

@delner delner commented Sep 20, 2019

This pull request adds multiplexing to Dalli instrumentation. Users can define configuration using the hostname port combo of the server to apply specific instrumentation settings:

Datadog.configure do |c|
  c.use :dalli, describes: 'localhost:1234', service_name: 'local-cache'
end

Then any Dalli client that sends to this hostname/port combo will have the trace settings applied, in this case commands sent to 'localhost:1234' will be tagged as the local-cache service. Commands that don't match this exactly will use default settings instead.

@delner delner added integrations Involves tracing integrations feature Involves a product feature labels Sep 20, 2019
@delner delner self-assigned this Sep 20, 2019
@delner delner changed the base branch from master to 0.28-dev September 20, 2019 02:03
@marcotc
Copy link
Member

marcotc commented Sep 20, 2019

If this is what we desire, the PR looks good!

@delner delner marked this pull request as ready for review October 1, 2019 17:17
@delner delner requested a review from a team October 1, 2019 17:17
@marcotc marcotc merged commit e2fd5c4 into 0.28-dev Oct 1, 2019
@marcotc marcotc deleted the feature/dalli_multiplexing branch October 1, 2019 17:19
@marcotc marcotc added this to the 0.28.0 milestone Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Involves a product feature integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants