-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rails component configuration #810
base: feature/integration_configuration_options
Are you sure you want to change the base?
Add Rails component configuration #810
Conversation
This is considered a WIP; still need to add unit and integration tests for this one. |
Just to clarify, the rails.active_record describes: :primary_db do |active_record| is not functional yet, is it? |
See #451 |
👏 Looks good! |
29dfdf8
to
ad3a87a
Compare
7cb8b61
to
09a774a
Compare
ad3a87a
to
fb2b660
Compare
@yijia-zhan we got this most of the way complete, but hit a snag with how defaults are evaluated under certain contexts; I will likely have to rework some of the design here to make it work. I'm unfortunately quite busy at the moment trying to get some features in order, but I will revisit this as soon as I have a chance. |
This would be really handy, I've got a number of Rails applications that connect out to other databases using ActiveRecord, but all of the config I've tried always puts everything under the same service - I'm assuming from the @delner are you able to advise on any current way to get separate dbs traced differently in a rails app ? This is what I'm trying to get working...
The rails main database is postgres - and all of the queries come through to DD on that service. |
Since this is very outdated, shall we go ahead and close it for now? |
This PR depends on #809.
As a follow-up to #450 and #764, this pull request adds block style configuration for Rails components available, to make configuration more expressive and customizable.
Some new configuration examples include:
The Rails configuration now allows all its sub-integrations (
rack, active_record, action_view, action_pack, active_support
) and their constituent options to configured in this manner.