Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quantize Redis AUTH command #776

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Quantize Redis AUTH command #776

merged 1 commit into from
Jul 15, 2019

Conversation

delner
Copy link
Contributor

@delner delner commented Jul 2, 2019

The Redis integration is not properly quantizing AUTH commands. This pull request applies quantization for AUTH commands.

@delner delner added bug Involves a bug integrations Involves tracing integrations labels Jul 2, 2019
@delner delner requested a review from brettlangdon July 2, 2019 21:18
@delner delner self-assigned this Jul 2, 2019
@delner delner modified the milestones: 0.26.0, 0.25.1 Jul 2, 2019
@delner delner force-pushed the fix/quantize_redis_auth_command branch from 612a08d to 083f52f Compare July 2, 2019 21:39
brettlangdon
brettlangdon approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@delner delner merged commit f9e1516 into master Jul 15, 2019
@delner delner deleted the fix/quantize_redis_auth_command branch July 15, 2019 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettlangdon brettlangdon brettlangdon approved these changes

Assignees

@delner delner

Labels
bug Involves a bug integrations Involves tracing integrations
Projects
None yet
Milestone
0.25.1
Development

Successfully merging this pull request may close these issues.
2 participants
@delner @brettlangdon