B3 Header Support #753
Merged
B3 Header Support #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettlangdon
added
core
delner
reviewed
May 13, 2019
There was a problem hiding this comment.
Great start overall. I think we might want to shuffle around some things while we have an opportunity to.
I'd also like to suggest that we consider making propagation styles a bit more modular, so that users with a need to define custom propagation have an API to do so. Even if this is might be a bit out of scope, then API changes we're putting in place here should at least be congruent with a plugin-friendly API, so we don't introduce breaking changes if we want to do so later.
I skipped on reviewing the tests until other changes are resolved.
palazzem
approved these changes
May 17, 2019
| # Truncate to trailing 16 characters if length is greater than 16 | ||
| # https://github.com/apache/incubator-zipkin/blob/21fe362899fef5c593370466bc5707d3837070c2/zipkin/src/main/java/zipkin2/storage/StorageComponent.java#L49-L53 | ||
| # DEV: This ensures we truncate B3 128-bit trace and span ids to 64-bit | ||
| value = value[value.length - 16, 16] if value.length > 16 |
brettlangdon
commented
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for parsing B3 headers for distributed tracing, including B3 single header.
We add two new configuration options:
propagation_extract_styleandpropagation_inject_stylewhich define which header formats we will try to parse and which we will inject into headers.By default we will attempt to parse every supported type of header. However, we only accept the propagated context if the values being propagated match, for example if we parse a different trace id from Datadog headers vs B3 headers then we do not use the context created.
By default we will only inject Datadog headers.