Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opentracing] Mark datadog_span.status = 1 when set_tag('error', true) #739

Merged
merged 2 commits into from
Apr 17, 2019
Merged

[opentracing] Mark datadog_span.status = 1 when set_tag('error', true) #739

merged 2 commits into from
Apr 17, 2019

Conversation

brettlangdon
Copy link
Member

Opentracing supports setting a tag error as a boolean. We were not doing anything with this tag, this code updates the opentracing span set_tag to look for error and translate that into setting the datadog_span.status property.

We also continue to set the tag as they requested, since that is what they'd expect.

@brettlangdon brettlangdon added this to the 0.23.0 milestone Apr 17, 2019
@brettlangdon brettlangdon changed the base branch from master to 0.23-dev April 17, 2019 00:03
@brettlangdon brettlangdon merged commit 0d08e84 into 0.23-dev Apr 17, 2019
@brettlangdon brettlangdon deleted the brettlangdon/opentracing.error branch April 17, 2019 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palazzem palazzem palazzem approved these changes

@pawelchcki pawelchcki pawelchcki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@brettlangdon @pawelchcki @palazzem