Fix custom log level manipulation and isolate logger unit tests #721
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #681 , a custom logger's log level can be unintentionally changed by Tracer configuration, which I was able to recreate locally.
self.debug_logging
assignment for whether the custom logger is an instance of theDatadog::Logger
class and is a noop if debug logging is not enabledtest/logger_test.rb
for new behavior.logger_test.rb
.Thanks for taking a look! Happy to address any feedback or anything else you think might be relevant here.