Fix Rack http_server.queue spans missing from distributed traces #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettlangdon
reviewed
Mar 7, 2019
brettlangdon
previously approved these changes
Mar 7, 2019
delner
force-pushed
the
fix/rack_http_server_queue_for_distributed_tracing
branch
from
50fb96a
to
296a107
Compare
|
@brettlangdon Rebased and ready for review again. |
brettlangdon
approved these changes
Mar 7, 2019
Merged
brettlangdon
deleted the
fix/rack_http_server_queue_for_distributed_tracing
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Rack application was on the receiving end of a distributed trace (e.g. 2nd service in chain), and it had enabled
request_queuing, then thehttp_server.queuespan did not receive the distributed trace ID and parent ID because it was processed before distributed tracing was. The span would instead end up in its own trace.This pull request moves the distributed tracing operation to the top, so
http_server.queuespans end up with the correct distributed tracing metadata, and are included into the trace.