Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Only require trace id for distributed tracing headers #708

Merged
merged 6 commits into from
Mar 6, 2019
Merged

[core] Only require trace id for distributed tracing headers #708

merged 6 commits into from
Mar 6, 2019

Conversation

brettlangdon
Copy link
Member

When testing the new synthetics integration we noticed that sending X-Datadog-Parent-Id: 0 causes us to ignore all distributed tracing headers.

@brettlangdon brettlangdon added the core Involves Datadog core libraries label Mar 5, 2019
@brettlangdon brettlangdon added this to the 0.20.0 milestone Mar 5, 2019
@brettlangdon brettlangdon requested a review from delner March 5, 2019 14:57
delner
delner approved these changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@delner delner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@brettlangdon brettlangdon merged commit fe4f7f7 into 0.20-dev Mar 6, 2019
@brettlangdon brettlangdon deleted the brettlangdon/valid.headers branch March 6, 2019 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palazzem palazzem palazzem left review comments

@delner delner delner approved these changes

Assignees
No one assigned
Labels
core Involves Datadog core libraries
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@brettlangdon @palazzem @delner