Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RestClient test not resetting #706

Merged
merged 1 commit into from
Mar 4, 2019
Merged

Fix RestClient test not resetting #706

merged 1 commit into from
Mar 4, 2019

Conversation

delner
Copy link
Contributor

@delner delner commented Mar 2, 2019

This pull request fixes the a RestClient test that doesn't reset configuration, causing tests to sometimes break depending which order they run in.

@delner delner added the dev/testing Involves testing processes (e.g. RSpec) label Mar 2, 2019
@delner delner added this to the 0.20.0 milestone Mar 2, 2019
@delner delner self-assigned this Mar 2, 2019
@delner delner requested a review from brettlangdon March 2, 2019 07:09
@delner
Copy link
Contributor Author

delner commented Mar 2, 2019

@brettlangdon Let's get this merged so CI doesn't flake out so much, then we can rebase the other open PRs on this.

@delner delner force-pushed the ci/fix_rest_client_config_reset branch from c9a0bac to ec2ccec Compare March 2, 2019 07:22
@delner delner merged commit d1dad71 into 0.20-dev Mar 4, 2019
@delner delner deleted the ci/fix_rest_client_config_reset branch March 4, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettlangdon brettlangdon brettlangdon approved these changes

Assignees

@delner delner

Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@delner @brettlangdon